Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

feat: add config.disableUntracedModulesWarn#1070

Merged
kjin merged 1 commit intogoogleapis:masterfrom
kjin:disable-untraced-modules-warn
Jul 18, 2019
Merged

feat: add config.disableUntracedModulesWarn#1070
kjin merged 1 commit intogoogleapis:masterfrom
kjin:disable-untraced-modules-warn

Conversation

@kjin
Copy link
Copy Markdown
Contributor

@kjin kjin commented Jul 17, 2019

Fixes #1066

@kjin kjin requested a review from a team July 17, 2019 19:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2019
@kjin kjin force-pushed the disable-untraced-modules-warn branch from 00e86bf to f4f9167 Compare July 18, 2019 17:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 18, 2019

Codecov Report

Merging #1070 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
+ Coverage   94.92%   94.93%   +<.01%     
==========================================
  Files          96       96              
  Lines        6386     6397      +11     
  Branches      496      498       +2     
==========================================
+ Hits         6062     6073      +11     
  Misses        166      166              
  Partials      158      158
Impacted Files Coverage Δ
src/tracing.ts 90% <ø> (ø) ⬆️
src/config.ts 100% <ø> (ø) ⬆️
src/index.ts 89.65% <100%> (+0.36%) ⬆️
test/test-modules-loaded-before-agent.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf423c...f4f9167. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logModulesLoadedBeforeTrace should log a warning not an error, and should have a flag to disable the warning

3 participants