Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

fix: warn if tracing might not work instead of err#1068

Merged
kjin merged 1 commit intogoogleapis:masterfrom
kjin:log-modules-as-warn
Jul 15, 2019
Merged

fix: warn if tracing might not work instead of err#1068
kjin merged 1 commit intogoogleapis:masterfrom
kjin:log-modules-as-warn

Conversation

@kjin
Copy link
Copy Markdown
Contributor

@kjin kjin commented Jul 15, 2019

Fixes #1066

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@kjin kjin requested a review from a team July 15, 2019 19:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logModulesLoadedBeforeTrace should log a warning not an error, and should have a flag to disable the warning

3 participants