fix: copy credentials in internal config#1052
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
+ Coverage 94.85% 94.86% +0.01%
==========================================
Files 96 96
Lines 6311 6326 +15
Branches 496 496
==========================================
+ Hits 5986 6001 +15
Misses 166 166
Partials 159 159
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
+ Coverage 94.85% 94.86% +0.01%
==========================================
Files 96 96
Lines 6311 6326 +15
Branches 496 496
==========================================
+ Hits 5986 6001 +15
Misses 166 166
Partials 159 159
Continue to review full report at Codecov.
|
| authOptions: Object.assign({}, mergedConfig, { | ||
| projectId: lastOf<string | undefined>( | ||
| mergedConfig.projectId, | ||
| process.env.GCLOUD_PROJECT |
There was a problem hiding this comment.
Doesn't the auth library already consult this environment variable?
There was a problem hiding this comment.
It's unfortunate but I realized that Trace Agent has historically regarded GCLOUD_PROJECT as taking precedence over the projectId config option, while the auth library does the opposite. Maybe it's possible that we change this now, though.
There was a problem hiding this comment.
That would be semver major :/. Not worth it.
| authOptions: Object.assign({}, mergedConfig, { | ||
| projectId: lastOf<string | undefined>( | ||
| mergedConfig.projectId, | ||
| process.env.GCLOUD_PROJECT |
There was a problem hiding this comment.
That would be semver major :/. Not worth it.
4 participants
Fixes #1048