Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

Commit 807d4ad

Browse files
authored
fix: fixup for node 8.11.2 (#755)
PR-URL: #755
1 parent 4733a68 commit 807d4ad

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

test/plugins/test-trace-http2.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,9 @@ describe('test-trace-http2', () => {
222222
// In Node 9.9+, the error handler is not added by default.
223223
s.on('error', () => {});
224224
setTimeout(() => {
225-
if (semver.satisfies(process.version, '>=9.4')) {
226-
// Node 9.4 removed rstWithInternalError() and uses added close().
225+
if (semver.satisfies(process.version, '^8.11||>=9.4')) {
226+
// Node 8.11/9.4 removed rstWithInternalError() in favor of new
227+
// close() function.
227228
s.close(http2.constants.NGHTTP2_INTERNAL_ERROR);
228229
} else {
229230
s.rstWithInternalError();

0 commit comments

Comments
 (0)