Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

Commit 210dc3f

Browse files
authored
feat: use small HTTP dependency (#858)
Use teenyRequest instead of request. This saves 900 ms at startup time.
1 parent 13f617a commit 210dc3f

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"@types/pify": "^3.0.0",
6464
"@types/protobufjs": "^5.0.31",
6565
"@types/proxyquire": "^1.3.28",
66-
"@types/request": "^2.0.8",
66+
"@types/request": "^2.47.1",
6767
"@types/semver": "^5.4.0",
6868
"@types/shimmer": "^1.0.1",
6969
"@types/tmp": "0.0.33",
@@ -103,10 +103,10 @@
103103
"hex2dec": "^1.0.1",
104104
"is": "^3.2.0",
105105
"methods": "^1.1.1",
106-
"request": "^2.83.0",
107106
"require-in-the-middle": "^3.0.0",
108107
"semver": "^5.4.1",
109108
"shimmer": "^1.2.0",
109+
"teeny-request": "^3.9.0",
110110
"uuid": "^3.0.1"
111111
}
112112
}

src/trace-writer.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ import {AxiosError} from 'axios';
1919
import * as gcpMetadata from 'gcp-metadata';
2020
import {OutgoingHttpHeaders} from 'http';
2121
import * as os from 'os';
22-
import * as request from 'request';
22+
import * as r from 'request'; // Only for type declarations.
23+
import {teenyRequest} from 'teeny-request';
2324

2425
import {Constants} from './constants';
2526
import {Logger} from './logger';
@@ -79,7 +80,7 @@ export class TraceWriter extends common.Service {
7980
private readonly logger: Logger) {
8081
super(
8182
{
82-
requestModule: request,
83+
requestModule: teenyRequest as typeof r,
8384
packageJson: pjson,
8485
projectIdRequired: false,
8586
baseUrl: 'https://cloudtrace.googleapis.com/v1',

test/test-trace-writer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import * as assert from 'assert';
1919
import {OutgoingHttpHeaders} from 'http';
2020
import * as nock from 'nock';
2121
import * as os from 'os';
22-
import {Response} from 'request';
22+
import {Response} from 'request'; // Only for type declarations.
2323
import * as shimmer from 'shimmer';
2424

2525
import {SpanKind, Trace} from '../src/trace';

0 commit comments

Comments
 (0)