Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

test: add test for behavior with invalid duration returned#964

Merged
aabmass merged 2 commits intogoogleapis:mainfrom
aabmass:retry-tests
Apr 14, 2025
Merged

test: add test for behavior with invalid duration returned#964
aabmass merged 2 commits intogoogleapis:mainfrom
aabmass:retry-tests

Conversation

@aabmass
Copy link
Copy Markdown
Contributor

@aabmass aabmass commented Apr 9, 2025

Follow up to #960. I verified this test behavior is the same before and after #960

@aabmass aabmass requested review from a team April 9, 2025 16:31
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. labels Apr 9, 2025
Copy link
Copy Markdown
Contributor

@psx95 psx95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to indicate that expected/default backoff is 500ms (unless its already documented in source code).

@aabmass
Copy link
Copy Markdown
Contributor Author

aabmass commented Apr 14, 2025

It's actually just part of the test confusingly. I can add a comment

@aabmass aabmass merged commit 047afa1 into googleapis:main Apr 14, 2025
13 checks passed
@aabmass aabmass deleted the retry-tests branch April 14, 2025 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants