Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

chore: add node 20 to github actions matrix#920

Merged
aabmass merged 1 commit intogoogleapis:mainfrom
aabmass:node20-gha
Feb 5, 2024
Merged

chore: add node 20 to github actions matrix#920
aabmass merged 1 commit intogoogleapis:mainfrom
aabmass:node20-gha

Conversation

@aabmass
Copy link
Copy Markdown
Contributor

@aabmass aabmass commented Feb 5, 2024

No description provided.

@aabmass aabmass requested review from a team February 5, 2024 15:56
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Feb 5, 2024

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. labels Feb 5, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c057bf1) 69.50% compared to head (8c45061) 69.65%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/logger.ts 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   69.50%   69.65%   +0.14%     
==========================================
  Files           7        7              
  Lines        1256     1262       +6     
  Branches       48       49       +1     
==========================================
+ Hits          873      879       +6     
  Misses        382      382              
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aabmass aabmass enabled auto-merge (squash) February 5, 2024 16:11
@aabmass
Copy link
Copy Markdown
Contributor Author

aabmass commented Feb 5, 2024 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

See this note

cloud-profiler-nodejs/.github/workflows/ci.yaml

Lines 1 to 6 in 8eb21a2

# This file is manually updated due to specific needs of the cloud
# profiler agent, e.g., not supporting Windows.
#
# It should be in sync with Google's template
# https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml
# for Node.js GCP libraries as much as possible.

That linked file supports node 20 as well

@aabmass aabmass merged commit b1bcb7a into googleapis:main Feb 5, 2024
@aabmass aabmass deleted the node20-gha branch February 5, 2024 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@psx95 psx95 psx95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aabmass @psx95