Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

chore: fix broken build and tests#874

Merged
aabmass merged 2 commits intogoogleapis:mainfrom
aabmass:fix-build
Jun 7, 2023
Merged

chore: fix broken build and tests#874
aabmass merged 2 commits intogoogleapis:mainfrom
aabmass:fix-build

Conversation

@aabmass
Copy link
Copy Markdown
Contributor

@aabmass aabmass commented Jun 7, 2023

Not sure how this got through CI

  • typescript issue with possibly undefined that can be supressed
  • system test was pulling in typescript 5 which doesn't work on the node version we are testing with

@aabmass aabmass requested review from a team June 7, 2023 21:14
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. labels Jun 7, 2023
@aabmass aabmass requested a review from punya June 7, 2023 21:15
@aabmass aabmass changed the title chore: fix build with new parseDuration types chore: fix build with parseDuration types Jun 7, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (572929d) 68.87% compared to head (568e03c) 68.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files           7        7           
  Lines        1253     1253           
  Branches       58       58           
=======================================
  Hits          863      863           
  Misses        389      389           
  Partials        1        1           
Impacted Files Coverage Δ
src/config.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aabmass aabmass changed the title chore: fix build with parseDuration types chore: fix broken build and tests Jun 7, 2023
@aabmass aabmass merged commit 46aefda into googleapis:main Jun 7, 2023
@aabmass aabmass deleted the fix-build branch June 7, 2023 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants