Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

build: replace wget with pre-installed curl#865

Merged
psx95 merged 1 commit intogoogleapis:mainfrom
psx95:remove-wget
Dec 13, 2022
Merged

build: replace wget with pre-installed curl#865
psx95 merged 1 commit intogoogleapis:mainfrom
psx95:remove-wget

Conversation

@psx95
Copy link
Copy Markdown
Contributor

@psx95 psx95 commented Dec 13, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

PR Description

Removes unnecessary installation of wget utility to download the go installation package. Uses the pre-installed Curl library instead, along with retry configured.

@psx95 psx95 requested review from a team, aabmass and punya December 13, 2022 17:19
@psx95 psx95 self-assigned this Dec 13, 2022
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Dec 13, 2022
@psx95 psx95 added type: cleanup An internal cleanup or hygiene concern. and removed size: xs Pull request size is extra small. labels Dec 13, 2022
@product-auto-label product-auto-label Bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Dec 13, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 13, 2022

Codecov Report

Base: 68.87% // Head: 68.87% // No change to project coverage 👍

Coverage data is based on head (d52af20) compared to base (3dd65e9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files           7        7           
  Lines        1253     1253           
  Branches       58       58           
=======================================
  Hits          863      863           
  Misses        389      389           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@psx95 psx95 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2022
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Dec 13, 2022
@psx95 psx95 merged commit 62d7e4f into googleapis:main Dec 13, 2022
@psx95 psx95 deleted the remove-wget branch December 13, 2022 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: xs Pull request size is extra small. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants