Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

fix: fix build so it includes expected files (and modify test to catch this)#847

Merged
nolanmar511 merged 1 commit intogoogleapis:mainfrom
nolanmar511:fix-build
Jul 7, 2022
Merged

fix: fix build so it includes expected files (and modify test to catch this)#847
nolanmar511 merged 1 commit intogoogleapis:mainfrom
nolanmar511:fix-build

Conversation

@nolanmar511
Copy link
Copy Markdown
Contributor

@nolanmar511 nolanmar511 commented Jul 7, 2022 •
edited by bcoe
Loading

This change does the following:

  • Remove "bindings" from the list of published files (this was left-over from when native portions of the agent were in this directory)
  • Modify integration_test.go so it lightly tests the build pathway.
  • Switch from import * as packageJson from '../package.json'; to const packageJson = require('../../package.json');, which results in the build from npm publish --dry-run including ".js" files.

BEGIN_COMMIT_OVERRIDE
fix: fix build so it includes expected files (and modify test to catch this)
END_COMMIT_OVERRIDE

@nolanmar511 nolanmar511 requested review from a team July 7, 2022 15:59
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. labels Jul 7, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #847 (64bea32) into main (3249ea1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files           7        7           
  Lines        1253     1253           
  Branches       58       58           
=======================================
  Hits          863      863           
  Misses        389      389           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3249ea1...64bea32. Read the comment docs.

@nolanmar511
Copy link
Copy Markdown
Contributor Author

nolanmar511 commented Jul 7, 2022

With change to integration_test.go only, I got the following error (reproducing the failure we've seen when trying to use v5.0.0)

  Thu Jul  7 16:03:35 UTC 2022: \033[96msrc/busybench.ts\033[0m:\033[93m14\033[0m:\033[93m27\033[0m - \033[91merror\033[0m\033[90m TS2307: \033[0mCannot find module '@google-cloud/profiler' or its corresponding type declarations.
            Thu Jul  7 16:03:35 UTC 2022: 
            Thu Jul  7 16:03:35 UTC 2022: \033[7m14\033[0m import * as profiler from '@google-cloud/profiler';
            Thu Jul  7 16:03:35 UTC 2022: \033[7m  \033[0m \033[91m                          ~~~~~~~~~~~~~~~~~~~~~~~~\033[0m
            Thu Jul  7 16:03:35 UTC 2022: 
            Thu Jul  7 16:03:35 UTC 2022: \033[96msrc/busybench.ts\033[0m:\033[93m33\033[0m:\033[93m5\033[0m - \033[91merror\033[0m\033[90m TS2304: \033[0mCannot find name 'setTimeout'.
            Thu Jul  7 16:03:35 UTC 2022:

If I can make this test pass, that's a a sign that the build process has been fixed.

@nolanmar511 nolanmar511 force-pushed the fix-build branch 4 times, most recently from 920fdb3 to 77548ae Compare July 7, 2022 17:53
@nolanmar511 nolanmar511 changed the title DO NOT REVIEW fix: test & fix build of this repo fix: fix build so it includes expected files (and modify test to catch this) Jul 7, 2022
@nolanmar511 nolanmar511 requested a review from amchiclet July 7, 2022 19:11
amchiclet
amchiclet approved these changes Jul 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@amchiclet amchiclet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@nolanmar511 nolanmar511 merged commit 6d9a5ca into googleapis:main Jul 7, 2022
@bcoe bcoe added the release-please:force-run To run release-please label Jul 8, 2022
@release-please release-please Bot removed the release-please:force-run To run release-please label Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@amchiclet amchiclet amchiclet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nolanmar511 @amchiclet @bcoe