This repository was archived by the owner on Feb 20, 2026. It is now read-only.
chore: do not specify @google-cloud/profiler in test package.json#845
Merged
nolanmar511 merged 1 commit intomainfrom Jul 6, 2022
Merged
chore: do not specify @google-cloud/profiler in test package.json#845nolanmar511 merged 1 commit intomainfrom
nolanmar511 merged 1 commit intomainfrom
Conversation
The benchmark test should use the version of @google-cloud/profiler at head on GitHub, so should not be specified in this package.json
product-auto-label
Bot
added
size: xs
nolanmar511
changed the title
Codecov Report
@@ Coverage Diff @@
## main #845 +/- ##
=======================================
Coverage 68.87% 68.87%
=======================================
Files 7 7
Lines 1253 1253
Branches 58 58
=======================================
Hits 863 863
Misses 389 389
Partials 1 1 Continue to review full report at Codecov.
|
nolanmar511
changed the title
amchiclet
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark test should use the version of @google-cloud/profiler at head on GitHub; specifying the version within this package.json seems potentially misleading (though may not be causing issue).