Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

chore(node): handle when package.json does not have a version#832

Merged
sofisl merged 3 commits intomainfrom
owl-bot-update-lock-079b0f3bd8427671745ec03a5179575b4c86a4e776fb6041427e553719c65c2b
May 18, 2022
Merged

chore(node): handle when package.json does not have a version#832
sofisl merged 3 commits intomainfrom
owl-bot-update-lock-079b0f3bd8427671745ec03a5179575b4c86a4e776fb6041427e553719c65c2b

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented May 10, 2022

  • test: failing test for repo without version in package.json

  • fix(node): handle when package.json does not have a version

  • chore: fix lint
    Source-Link: googleapis/synthtool@2643dfe
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:079b0f3bd8427671745ec03a5179575b4c86a4e776fb6041427e553719c65c2b

* test: failing test for repo without version in package.json

* fix(node): handle when package.json does not have a version

* chore: fix lint
Source-Link: googleapis/synthtool@2643dfe
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:079b0f3bd8427671745ec03a5179575b4c86a4e776fb6041427e553719c65c2b
@gcf-owl-bot gcf-owl-bot Bot requested review from a team May 10, 2022 15:59
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 10, 2022
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. labels May 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 10, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2022

Codecov Report

Merging #832 (6cdfaf8) into main (c224211) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   69.15%   69.15%           
=======================================
  Files           7        7           
  Lines        1248     1248           
  Branches       58       58           
=======================================
  Hits          863      863           
  Misses        384      384           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c224211...6cdfaf8. Read the comment docs.

@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 13, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 13, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 18, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 18, 2022
@sofisl sofisl merged commit 74e287d into main May 18, 2022
@sofisl sofisl deleted the owl-bot-update-lock-079b0f3bd8427671745ec03a5179575b4c86a4e776fb6041427e553719c65c2b branch May 18, 2022 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. owl-bot-update-lock size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants