Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

fix: lazily init logging#801

Merged
aabmass merged 6 commits intogoogleapis:mainfrom
jonahsnider:fix/logging-init
Feb 2, 2024
Merged

fix: lazily init logging#801
aabmass merged 6 commits intogoogleapis:mainfrom
jonahsnider:fix/logging-init

Conversation

@jonahsnider
Copy link
Copy Markdown
Contributor

Fixes #800

@jonahsnider jonahsnider requested review from a team February 6, 2022 23:04
@product-auto-label product-auto-label Bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Feb 6, 2022
@jonahsnider jonahsnider changed the title Lazily init logging fix: lazily init logging Feb 6, 2022
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label May 3, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2022

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c057bf1) 69.50% compared to head (fcac62d) 69.65%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/logger.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
+ Coverage   69.50%   69.65%   +0.14%     
==========================================
  Files           7        7              
  Lines        1256     1262       +6     
  Branches       48       49       +1     
==========================================
+ Hits          873      879       +6     
  Misses        382      382              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@punya punya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@punya punya added the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2022
@punya punya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@aabmass aabmass added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@aabmass aabmass added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@aabmass aabmass enabled auto-merge (squash) February 2, 2024 21:10
@aabmass aabmass added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 2, 2024
@aabmass aabmass merged commit 04853a9 into googleapis:main Feb 2, 2024
@jonahsnider jonahsnider deleted the fix/logging-init branch February 3, 2024 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Just importing this package in a non-GCP environment logs errors to console

4 participants