Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

build: use standard CI config #710

Merged
JustinBeckwith merged 6 commits into from
Nov 4, 2020
Merged

build: use standard CI config #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6895ba9
build: use standard CI config
JustinBeckwith Nov 2, 2020
daa3b4a
Merge branch 'master' into acts2
JustinBeckwith Nov 2, 2020
859717d
Merge branch 'master' into acts2
JustinBeckwith Nov 2, 2020
168cd4d
Merge branch 'master' into acts2
Nov 2, 2020
8217169
Merge branch 'master' into acts2
JustinBeckwith Nov 4, 2020
31da2c1
ugh
JustinBeckwith Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ branchProtectionRules:
- "lint"
- "test (10)"
- "test (12)"
- "test (13)"
- "test (14)"
- "test (15)"
- "windows"
- "system-test"
36 changes: 10 additions & 26 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,25 @@ on:
branches:
- master
pull_request:
schedule:
- cron: '0 2 * * *' # Run everyday, at 2AM UTC.
name: ci
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 13, 14]
node: [10, 12, 14, 15]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- run: node --version
# The first installation step ensures that all of our production
# dependencies work on the given Node.js version, this helps us find
# dependencies that don't match our engines field:
- run: npm install --production --engine-strict --ignore-scripts --no-package-lock
# Clean up the production install, before installing dev/production:
- run: rm -rf node_modules
- run: npm install
- run: npm test
- name: coverage
Expand All @@ -31,7 +35,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14
- run: npm install
- run: npm test
- name: coverage
Expand All @@ -45,7 +49,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14
- run: npm install
- run: npm run lint
docs:
Expand All @@ -54,26 +58,6 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14
- run: npm install
- run: npm run docs-test
system-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
- run: npm install
- run: npm run system-test
- name: coverage
uses: codecov/codecov-action@v1
with:
name: actions system-test
fail_ci_if_error: false
golint:
runs-on: ubuntu-latest
container: golang:latest
steps:
- run: gofmtdiff=$(gofmt -s -d .) && if [ -n "$gofmtdiff" ]; then printf 'gofmt -s found:\n%s\n' "$gofmtdiff" && exit 1; fi
- run: go get -u golang.org/x/lint/golint && golintlint=$($GOPATH/bin/golint ./...) && if [ -n "$golintlint" ]; then printf 'golint found:\n%s\n' "$golintlint" && exit 1; fi
29 changes: 29 additions & 0 deletions .github/workflows/ci2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
on:
push:
branches:
- master
pull_request:
schedule:
- cron: '0 2 * * *' # Run everyday, at 2AM UTC.
name: ci-profiler
jobs:
system-test:
Copy link
Copy Markdown
Contributor Author

@JustinBeckwith JustinBeckwith Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nolanmar511 curious - why do we run system tests as a GitHub action, and not rely on the default kokoro config we have set up elsewhere?

Copy link
Copy Markdown
Contributor

@nolanmar511 nolanmar511 Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at my PR history, I think this was done to start running all tests with Node 13 a bit earlier (#585).
It may have also improve cove coverage results.

Copy link
Copy Markdown
Contributor Author

@JustinBeckwith JustinBeckwith Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - so these are kinda 2 different things:

  • We wanted node 13 testing faster here than we rolled it out elsewhere. Moving forward, we just need to be far more bullish about getting these in the matrix as soon as they're released. Good news is that 15 rolled out super fast.
  • For system tests - I just don't want the duplicate config here to run it as an action unless we have a goodish reason :)

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
- run: npm install
- run: npm run system-test
- name: coverage
uses: codecov/codecov-action@v1
with:
name: actions system-test
fail_ci_if_error: false
golint:
runs-on: ubuntu-latest
container: golang:latest
steps:
- run: gofmtdiff=$(gofmt -s -d .) && if [ -n "$gofmtdiff" ]; then printf 'gofmt -s found:\n%s\n' "$gofmtdiff" && exit 1; fi
- run: go get -u golang.org/x/lint/golint && golintlint=$($GOPATH/bin/golint ./...) && if [ -n "$golintlint" ]; then printf 'golint found:\n%s\n' "$golintlint" && exit 1; fi
2 changes: 1 addition & 1 deletion synth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@

common_templates = gcp.CommonTemplates()
templates = common_templates.node_library(source_location='build/src')
s.copy(templates, excludes=[".github/workflows/ci.yaml"])
s.copy(templates)
node.install()
node.fix()