This repository was archived by the owner on Feb 20, 2026. It is now read-only.
chore(deps): pin pprof #539
Merged
kalyanac merged 1 commit intogoogleapis:masterfrom Sep 11, 2019
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 75.73% 75.73%
=======================================
Files 7 7
Lines 272 272
Branches 56 56
=======================================
Hits 206 206
Misses 50 50
Partials 16 16Continue to review full report at Codecov.
|
kalyanac
approved these changes
Sep 11, 2019
aalexand
reviewed
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@google-cloud/profilerdepends heavily on thepprofmodule.We want to be sure that changes to
pprofthat introduce bugs or problems in@google-cloud/profilercan be caught by@google-cloud/profiler's presubmit tests, rather than immediately impacting@google-cloud/profileras its running in prod.This will allow us to concentrate testing in this repository, rather than duplicate all testing here and in https://github.com/google/pprof-nodejs.