Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

build: use standard kokoro configuration#502

Merged
JustinBeckwith merged 6 commits intomasterfrom
assimilate
Jun 5, 2019
Merged

build: use standard kokoro configuration#502
JustinBeckwith merged 6 commits intomasterfrom
assimilate

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented May 30, 2019

This adds a synth.py, opting this repository into the standard nodejs template we use across all of our libraries.

Fixes #500

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2019

Codecov Report

Merging #502 into master will increase coverage by 3.71%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   72.86%   76.57%   +3.71%     
==========================================
  Files           7        7              
  Lines         269      269              
  Branches       56       56              
==========================================
+ Hits          196      206      +10     
+ Misses         58       48      -10     
  Partials       15       15
Impacted Files Coverage Δ
ts/src/config.ts 100% <ø> (ø) ⬆️
ts/src/profiler.ts 89.3% <100%> (+4.4%) ⬆️
ts/src/logger.ts 53.84% <100%> (ø) ⬆️
ts/src/index.ts 59.78% <80%> (+3.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef20ce...98455ad. Read the comment docs.

@nolanmar511 nolanmar511 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2019
@nolanmar511 nolanmar511 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2019
Copy link
Copy Markdown
Contributor

@nolanmar511 nolanmar511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once lint checks are passing.

@nolanmar511
Copy link
Copy Markdown
Contributor

nolanmar511 commented Jun 5, 2019

I really don't understand why lint checks are failing.
They pass locally, and with PRs I've sent recently.

@JustinBeckwith JustinBeckwith merged commit bafa51e into master Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add synth.py, start auto-generating .kokoro, etc.

4 participants