Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

refactor: drop dependency on pify#493

Merged
nolanmar511 merged 3 commits intomasterfrom
nopif
May 23, 2019
Merged

refactor: drop dependency on pify#493
nolanmar511 merged 3 commits intomasterfrom
nopif

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented May 23, 2019

Now that we dropped support for node.js 6, we can just use util.promisify.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 23, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2019
@nolanmar511
Copy link
Copy Markdown
Contributor

The ci/kokoro: docs failure is unrelated to this change.

@jkwlui -- any ideas? It looks like it might be a test that's set up internally with Kokoro, but the build config isn't yet in this repo, since it failed with:

 Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration under /tmp/workspace/workspace/cloud-devrel/client-libraries/nodejs/presubmit/googleapis/cloud-profiler-nodejs/node10/docs/src/github/cloud-profiler-nodejs/.kokoro/presubmit/node10

@nolanmar511 nolanmar511 merged commit 0b605da into master May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants