This repository was archived by the owner on Feb 20, 2026. It is now read-only.
fix(deps): update dependency @google-cloud/common to v1#482
Merged
nolanmar511 merged 2 commits intomasterfrom May 13, 2019
Merged
fix(deps): update dependency @google-cloud/common to v1#482nolanmar511 merged 2 commits intomasterfrom
nolanmar511 merged 2 commits intomasterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
|
Tests failing with: Will need to update code. |
|
@nolanmar511 pretty sure the common module dropped support for supplying a custom request module, so I think just deleting those lines will make CI happy? No idea if this module depended on that functionality or not. |
JustinBeckwith
approved these changes
May 10, 2019
renovate
Bot
force-pushed
the
renovate/google-cloud-common-1.x
branch
from
43a848a to
33fca0a
Compare
nolanmar511
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=========================================
- Coverage 73.33% 73.23% -0.1%
=========================================
Files 6 6
Lines 270 269 -1
Branches 56 56
=========================================
- Hits 198 197 -1
Misses 57 57
Partials 15 15
Continue to review full report at Codecov.
|
Contributor
|
Merging in. Code coverage dropped by 0.1% because a line that was removed has coverage. I'm ignoring that failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.31.0->^1.0.0Release Notes
googleapis/nodejs-common
v1.0.0Compare Source
Bug Fixes
Build System
Miscellaneous Chores
BREAKING CHANGES
v0.32.1Compare Source
Bug Fixes
Build System
Miscellaneous Chores
BREAKING CHANGES
v0.32.0Compare Source
04-02-2019 15:11 PDT
BREAKING CHANGE: This PR removes the ability to configure a custom implementation of the Request module. This was necessary when we were migrating from request to teeny-request, but that migration is now complete. All interfaces at accepted a custom implementation of request will no longer accept one. teeny-request is now just included in the box.
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.