Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

fix: update dependencies and tsconfig to support Node 6#466

Merged
kalyanac merged 1 commit intogoogleapis:masterfrom
nolanmar511:tsconfig
Apr 26, 2019
Merged

fix: update dependencies and tsconfig to support Node 6#466
kalyanac merged 1 commit intogoogleapis:masterfrom
nolanmar511:tsconfig

Conversation

@nolanmar511
Copy link
Copy Markdown
Contributor

@nolanmar511 nolanmar511 commented Apr 26, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
JustinBeckwith
JustinBeckwith reviewed Apr 26, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we just rely on the version in the tsconfig, which as of today in [email protected] is es2015. When you upgrade to [email protected], it's gonna bump to es2016 by design. Why hard code it?

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2019

Codecov Report

Merging #466 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files           4        4           
  Lines         212      212           
  Branches       24       24           
=======================================
  Hits          161      161           
  Misses         48       48           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081c153...f29da31. Read the comment docs.

@nolanmar511 nolanmar511 changed the title fix: add es2015 as target for tsconfig.json fix: update dependencies and tsconfig to support Node 6 Apr 26, 2019
@nolanmar511
Copy link
Copy Markdown
Contributor Author

nolanmar511 commented Apr 26, 2019

Clarified the title.
We have continuous integration tests which use Node 6, and those are failing.
I want to get those tests passing, the go through a more conscious effort to drop support for Node 6.

@nolanmar511
Copy link
Copy Markdown
Contributor Author

nolanmar511 commented Apr 26, 2019

Closing this.

It's probably just too hard to support Node 6, and Node 6 is basically end of life anyways.

@nolanmar511
Copy link
Copy Markdown
Contributor Author

nolanmar511 commented Apr 26, 2019

Actually, want to get this change in.
It will give time for a more graceful wrap-up of Node 6 support.

@kalyanac kalyanac merged commit b7b0714 into googleapis:master Apr 26, 2019
@kalyanac kalyanac mentioned this pull request Apr 26, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nolanmar511 @JustinBeckwith @googlebot @kalyanac