fix: relax service name requirements to allow starting with numbers (#828)

amchiclet · web-flow · commit fe0f1ccd14c2 · 2022-05-04T13:32:13.000-07:00
diff --git a/src/index.ts b/src/index.ts
@@ -25,7 +25,7 @@ import {Profiler} from './profiler';
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const pjson = require('../../package.json');
-const serviceRegex = /^[a-z]([-a-z0-9_.]{0,253}[a-z0-9])?$/;
+const serviceRegex = /^[a-z0-9]([-a-z0-9_.]{0,253}[a-z0-9])?$/;
 
 function hasService(
   config: Config
diff --git a/test/test-init-config.ts b/test/test-init-config.ts
@@ -257,7 +257,7 @@ describe('createProfiler', () => {
     } catch (e) {
       assert.strictEqual(
         e.message,
-        'Service serviceName does not match regular expression "/^[a-z]([-a-z0-9_.]{0,253}[a-z0-9])?$/"'
+        'Service serviceName does not match regular expression "/^[a-z0-9]([-a-z0-9_.]{0,253}[a-z0-9])?$/"'
       );
     }
   });

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,7 @@ describe('createProfiler', () => {`
`257`	`257`	`} catch (e) {`
`258`	`258`	`assert.strictEqual(`
`259`	`259`	`e.message,`
`260`		`- 'Service serviceName does not match regular expression "/^[a-z]([-a-z0-9_.]{0,253}[a-z0-9])?$/"'`
	`260`	`+ 'Service serviceName does not match regular expression "/^[a-z0-9]([-a-z0-9_.]{0,253}[a-z0-9])?$/"'`
`261`	`261`	`);`
`262`	`262`	`}`
`263`	`263`	`});`