Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Enable maxExpandFrames config option#85

Merged
matthewloring merged 1 commit intogoogleapis:masterfrom
matthewloring:exp-frames
Jan 22, 2016
Merged

Enable maxExpandFrames config option#85
matthewloring merged 1 commit intogoogleapis:masterfrom
matthewloring:exp-frames

Conversation

@matthewloring
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2016
@matthewloring
Copy link
Copy Markdown
Contributor Author

@ofrobots PTAL.

lib/state.js Outdated

This comment was marked as spam.

This comment was marked as spam.

@ofrobots
Copy link
Copy Markdown
Contributor

LGTM once tests pass. Suggestion about error StatusMessage can be addressed in a follow on PR.

lib/state.js Outdated

This comment was marked as spam.

This comment was marked as spam.

@ofrobots
Copy link
Copy Markdown
Contributor

LGTM w/ comments.

@ofrobots
Copy link
Copy Markdown
Contributor

Ugh. You'll have to use util._extend. I forgot that Object.assign has only been there since V8 4.5.

@matthewloring matthewloring merged commit 14ac9e4 into googleapis:master Jan 22, 2016
@matthewloring matthewloring deleted the exp-frames branch January 22, 2016 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants