This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Add debugger support for Cloud Run. See b/112087600 for context#671
Merged
DominicKramer merged 4 commits intogoogleapis:masterfrom Apr 30, 2019
Merged
Add debugger support for Cloud Run. See b/112087600 for context#671DominicKramer merged 4 commits intogoogleapis:masterfrom
DominicKramer merged 4 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
DominicKramer
approved these changes
Apr 16, 2019
Contributor
DominicKramer
left a comment
DominicKramer
left a comment
There was a problem hiding this comment.
Thanks for creating this PR. It is much appreciated. I think it looks good to me with one comment. I think the approach you took is correct, but I just want to make sure.
bcoe
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 13 13
Lines 776 776
Branches 66 66
=======================================
Hits 692 692
Misses 67 67
Partials 17 17
Continue to review full report at Codecov.
|
Contributor
|
/cc @kjin @nolanmar511: the same may be needed on Trace and Profiler. |
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
DominicKramer
added
status: blocked
DominicKramer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
DominicKramer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Partially) Fixes b/112087600.