Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

fix(deps): update dependency @google-cloud/common to ^0.32.0#667

Merged
JustinBeckwith merged 2 commits intomasterfrom
renovate/google-cloud-common-0.x
Apr 12, 2019
Merged

fix(deps): update dependency @google-cloud/common to ^0.32.0#667
JustinBeckwith merged 2 commits intomasterfrom
renovate/google-cloud-common-0.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Apr 3, 2019

This PR contains the following updates:

Package Type Update Change References
@​google-cloud/common dependencies minor ^0.31.0 -> ^0.32.0 source

Release Notes

googleapis/nodejs-common

v0.32.0

Compare Source

04-02-2019 15:11 PDT

BREAKING CHANGE: This PR removes the ability to configure a custom implementation of the Request module. This was necessary when we were migrating from request to teeny-request, but that migration is now complete. All interfaces at accepted a custom implementation of request will no longer accept one. teeny-request is now just included in the box.


Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2019
@JustinBeckwith JustinBeckwith force-pushed the renovate/google-cloud-common-0.x branch from 7038376 to 0d0115b Compare April 4, 2019 15:47
@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Apr 4, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@JustinBeckwith JustinBeckwith added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
yoshi-automation pushed a commit to googleapis/nodejs-common that referenced this pull request Apr 4, 2019
fix: teeny-request should be dependency

Fixes issues seen here: googleapis/cloud-debug-nodejs#667

teeny-request is required in util.js, but is only currently present as a dev-dependency.

- [x] Tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)


#403 automerged by dpebot
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 10, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2019

Codecov Report

Merging #667 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage    88.9%   88.87%   -0.03%     
==========================================
  Files          15       15              
  Lines         946      944       -2     
  Branches       83       83              
==========================================
- Hits          841      839       -2     
  Misses         87       87              
  Partials       18       18
Impacted Files Coverage Δ
src/client/stackdriver/debug.ts 83.33% <ø> (-2.39%) ⬇️
src/agent/controller.ts 87.17% <100%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50abf1d...0d0115b. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 00565ce into master Apr 12, 2019
@renovate renovate bot deleted the renovate/google-cloud-common-0.x branch April 12, 2019 00:44
robertomartinez09515 added a commit to robertomartinez09515/nodejs-common-create that referenced this pull request Jul 25, 2022
fix: teeny-request should be dependency

Fixes issues seen here: googleapis/cloud-debug-nodejs#667

teeny-request is required in util.js, but is only currently present as a dev-dependency.

- [x] Tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)


#403 automerged by dpebot
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants