Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

chore: drop duplicate nyc config#665

Merged
JustinBeckwith merged 3 commits intomasterfrom
nonyc
Apr 2, 2019
Merged

chore: drop duplicate nyc config#665
JustinBeckwith merged 3 commits intomasterfrom
nonyc

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

This is already covered in the .nycrc we bring into every repository. @bcoe is working on fixes in the common file to keep us all consistent and happy :)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2019
@JustinBeckwith JustinBeckwith requested review from a team and DominicKramer March 31, 2019 18:16
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2019

Codecov Report

Merging #665 into master will decrease coverage by 3.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #665      +/-   ##
=========================================
- Coverage   92.88%   88.9%   -3.99%     
=========================================
  Files          38      15      -23     
  Lines        3570     946    -2624     
  Branches      108      83      -25     
=========================================
- Hits         3316     841    -2475     
+ Misses        230      87     -143     
+ Partials       24      18       -6
Impacted Files Coverage Δ
test/mock-logger.ts
test/test-duplicate-nested-expressions.ts
test/test-try-catch.ts
test/auth-request.ts
test/test-evaluated-expressions.ts
test/test-v8debugapi.ts
test/test-expression-side-effect.ts
test/test-duplicate-expressions.ts
test/debugger.ts
test/test-circular.ts
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207e512...4b7c8c0. Read the comment docs.

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Apr 1, 2019
@JustinBeckwith JustinBeckwith merged commit f4c0003 into master Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants