This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: add webpack support to the Sourcemapper#640
Merged
DominicKramer merged 6 commits intogoogleapis:masterfrom Feb 20, 2019
Merged
fix: add webpack support to the Sourcemapper#640DominicKramer merged 6 commits intogoogleapis:masterfrom
DominicKramer merged 6 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
This PR requires PR #643 to land before continuing. |
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=========================================
+ Coverage 92.89% 92.9% +0.01%
=========================================
Files 38 38
Lines 3545 3554 +9
Branches 105 106 +1
=========================================
+ Hits 3293 3302 +9
Misses 229 229
Partials 23 23
Continue to review full report at Codecov.
|
Contributor
Author
|
I was able to update this PR so that it does not depend on PR #643. That allows us to support webpack sourcemaps without having drop support for Node 6. |
Contributor
|
/cc @nolanmar511 profiler may need some changes to support webpacked source code as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #616