This repository was archived by the owner on Apr 3, 2024. It is now read-only.
test: use unique service context for e2e tests#638
Merged
ofrobots merged 5 commits intogoogleapis:masterfrom Feb 15, 2019
Merged
test: use unique service context for e2e tests#638ofrobots merged 5 commits intogoogleapis:masterfrom
ofrobots merged 5 commits intogoogleapis:masterfrom
Conversation
Concurrent execution of the e2e tests is causing flakiness.
googlebot
added
the
cla: yes
DominicKramer
previously approved these changes
Feb 14, 2019
Contributor
DominicKramer
left a comment
DominicKramer
left a comment
There was a problem hiding this comment.
LGTM once the tests pass.
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
- Coverage 92.91% 92.89% -0.03%
==========================================
Files 38 38
Lines 3544 3546 +2
Branches 105 105
==========================================
+ Hits 3293 3294 +1
- Misses 228 229 +1
Partials 23 23
Continue to review full report at Codecov.
|
DominicKramer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
Author
|
Okay, I finally understand the flakiness. Should be fixed now. TBR= @DominicKramer |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent execution of the e2e tests is causing flakiness.