This repository was archived by the owner on Apr 3, 2024. It is now read-only.
feat: make logpoint function customizable#634
Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom Feb 15, 2019
Merged
feat: make logpoint function customizable#634JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
DominicKramer
approved these changes
Feb 13, 2019
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
Author
|
This is blocked on #635 landing. |
ofrobots
force-pushed
the
fix-458
branch
2 times, most recently
from
59ac3f9 to
4e6d9fd
Compare
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 38 38
Lines 3544 3544
Branches 105 105
=======================================
Hits 3293 3293
Misses 228 228
Partials 23 23
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 92.89% 92.89% +<.01%
==========================================
Files 38 38
Lines 3545 3546 +1
Branches 105 105
==========================================
+ Hits 3293 3294 +1
Misses 229 229
Partials 23 23
Continue to review full report at Codecov.
|
By default we use console.log for printing logpoint messages. This PR adds a config option to allow users to customize the log function. This can be useful in situations where the logs are being sent to 3rd parties or need post-processing. Fixes: googleapis#458
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default we use console.log for printing logpoint messages. This PR
adds a config option to allow users to customize the log function. This
can be useful in situations where the logs are being sent to 3rd parties
or need post-processing.
Fixes: #458