This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: avoid spurious 'unable to clear' errors#624
Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom Feb 8, 2019
Merged
fix: avoid spurious 'unable to clear' errors#624JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
Conversation
In the case where we are not able to set a server breakpoint, for example, when the file doesn't exist locally or is ambiguous, we are emitted a spurious error in the log: Error: Unable to clear breakpoint in v8 This change detects the situation and aviods deleting a non-existent breakpoint.
JustinBeckwith
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where we are not able to set a server breakpoint, for
example, when the file doesn't exist locally or is ambiguous, we are
emitted a spurious error in the log:
Error: Unable to clear breakpoint in v8
This change detects the situation and aviods deleting a non-existent
breakpoint.