This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix the script path we use to set the v8 bp#55
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Dec 4, 2015
Merged
Conversation
We were using the original path provided by the Debug API rather than the app local path we computed based on the file-matching heuristics.
googlebot
added
the
cla: yes
Contributor
|
😨 Scary that this made it so far. Maybe the e2e tests could be augmented to cover this case. LGTM. |
Contributor
Author
|
It does have to be a test-case that moves files in order to make the bug to manifest. Either an e2e test, or at least, a slightly more advanced test case is needed here. Opened #56. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using the original path provided by the Debug API rather than the app
local path we computed based on the file-matching heuristics.
@matthewloring PTAL.