This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix reporting of file not found error#49
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Nov 30, 2015
Merged
Conversation
The callback was getting called with the wrong value resulting the breakpoint never being updated w/ the error on the server side. This causes the client to wait upon a breakpoint forever even though we didn't even set the breakpoint in the debuglet.
googlebot
added
the
cla: yes
Contributor
Author
|
@matthewloring ptal. |
Contributor
|
Is there a way that the e2e tests could be expanded to make sure this path is tested somehow? |
Contributor
|
Just saw #50, LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback was getting called with the wrong value resulting the breakpoint
never being updated w/ the error on the server side. This causes the client to
wait upon a breakpoint forever even though we didn't even set the breakpoint in
the debuglet.