This repository was archived by the owner on Apr 3, 2024. It is now read-only.
chore: update semver to 5.5.0#421
Merged
DominicKramer merged 1 commit intogoogleapis:masterfrom Apr 27, 2018
Merged
Conversation
The current `package.json` requires `semver@'^5.1.0'`. However, the `semver.coerce` function does not exist in that version. As part of PR googleapis#407, `package-lock.json` was regenerated and specified semver version 5.5.0 should be used. When the tests were run, Node >= 8 would use package-lock.json and installed semver 5.5.0 that has `semver.coerce`. In addition, for Node < 8, the tests would install the latest version of semver (5.5.0) that has `semver.coerce`. As a result, the system and unit tests would all pass. However, if user code, or the code of its dependencies, requires only semver@'^5.1.0', and that version was installed prior to installing @google-cloud/debug-agent, version `5.1.0` of semver could be used. However since this version doesn't have the `semver.coerce` function, the debug agent would crash on startup. This is what happened in issue googleapis#420. Fixes: googleapis#420
googlebot
added
the
cla: yes
ofrobots
approved these changes
Apr 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
package.jsonrequiressemver@'^5.1.0'. However,the
semver.coercefunction does not exist in that version.As part of PR #407,
package-lock.jsonwas regenerated andspecified semver version 5.5.0 should be used.
When the tests were run, Node >= 8 would use package-lock.json
and installed semver 5.5.0 that has
semver.coerce.In addition, for Node < 8, the tests would install the latest
version of semver (5.5.0) that has
semver.coerce.As a result, the system and unit tests would all pass.
However, if user code, or the code of its dependencies, requires
only semver@'^5.1.0', and that version was installed prior to
installing @google-cloud/debug-agent, version
5.1.0of semvercould be used. However since this version doesn't have the
semver.coercefunction, the debug agent would crash onstartup. This is what happened in issue #420.
Fixes: #420