This repository was archived by the owner on Apr 3, 2024. It is now read-only.
chore: update gcp-metadata to 0.6.3#407
Merged
DominicKramer merged 6 commits intogoogleapis:masterfrom Mar 16, 2018
Merged
Conversation
googlebot
added
the
cla: yes
ofrobots
changed the title
gcp-metadata to 0.6.3
Contributor
|
This commit also changes the typescript version, so the issue title isn't accurate. Is the typescript change intentional? |
Contributor
Author
|
The Typescript change is required by the gcp-metadata change. I'll update the description. |
This change should fix the unit test, but further investigation is needed to determine why this change is necessary.
This was referenced Mar 15, 2018
ofrobots
reviewed
Mar 16, 2018
test/nocks.ts
Outdated
| validator = validator || accept; | ||
| return nock('https://accounts.google.com') | ||
| .post('/o/oauth2/token', validator) | ||
| return nock(/https:\/\/(accounts\.google\.com|www\.googleapis\.com)/) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
DominicKramer
added a commit
to DominicKramer/cloud-debug-nodejs
that referenced
this pull request
Apr 27, 2018
The current `package.json` requires `semver@'^5.1.0'`. However, the `semver.coerce` function does not exist in that version. As part of PR googleapis#407, `package-lock.json` was regenerated and specified semver version 5.5.0 should be used. When the tests were run, Node >= 8 would use package-lock.json and installed semver 5.5.0 that has `semver.coerce`. In addition, for Node < 8, the tests would install the latest version of semver (5.5.0) that has `semver.coerce`. As a result, the system and unit tests would all pass. However, if user code, or the code of its dependencies, requires only semver@'^5.1.0', and that version was installed prior to installing @google-cloud/debug-agent, version `5.1.0` of semver could be used. However since this version doesn't have the `semver.coerce` function, the debug agent would crash on startup. This is what happened in issue googleapis#420. Fixes: googleapis#420
DominicKramer
added a commit
that referenced
this pull request
Apr 27, 2018
The current `package.json` requires `semver@'^5.1.0'`. However, the `semver.coerce` function does not exist in that version. As part of PR #407, `package-lock.json` was regenerated and specified semver version 5.5.0 should be used. When the tests were run, Node >= 8 would use package-lock.json and installed semver 5.5.0 that has `semver.coerce`. In addition, for Node < 8, the tests would install the latest version of semver (5.5.0) that has `semver.coerce`. As a result, the system and unit tests would all pass. However, if user code, or the code of its dependencies, requires only semver@'^5.1.0', and that version was installed prior to installing @google-cloud/debug-agent, version `5.1.0` of semver could be used. However since this version doesn't have the `semver.coerce` function, the debug agent would crash on startup. This is what happened in issue #420. Fixes: #420
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcp-metadataversion0.6.3uses Typescript 2.7. Therefore, for this module to compile, its Typescript version has been updated.