Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

feat: GAE_DEPLOYMENT_ID used for minor version#400

Merged
DominicKramer merged 2 commits intogoogleapis:masterfrom
DominicKramer:feat/use-gae-deployment-id
Feb 22, 2018
Merged

feat: GAE_DEPLOYMENT_ID used for minor version#400
DominicKramer merged 2 commits intogoogleapis:masterfrom
DominicKramer:feat/use-gae-deployment-id

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

@DominicKramer DominicKramer commented Feb 21, 2018 •
edited
Loading

The GAE_DEPLOYMENT_ID environment variable (with a fallback to
GAE_MINOR_VERSION) will be used as the default value of
minorVersion_.

Note that the GAE_DEPLOYMENT_ID environment
variable is now set on AppEngine Flex.

@DominicKramer
feat: GAE_DEPLOYMENT_ID used for minor version
84af958 
The `GAE_DEPLOYMENT_ID` environment variable (with a fallback to
`GAE_MINOR_VERSION`) will be used as the default value of
`minorVersion_`.
@DominicKramer DominicKramer requested a review from a team February 21, 2018 23:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2018
@jinwoo
Copy link
Copy Markdown
Contributor

jinwoo commented Feb 21, 2018

Looks like tests must be updated?

@DominicKramer
Copy link
Copy Markdown
Contributor Author

DominicKramer commented Feb 22, 2018

PTAL

@DominicKramer DominicKramer merged commit f6985f7 into googleapis:master Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jinwoo jinwoo jinwoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DominicKramer @jinwoo @googlebot