This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Update gcp-metadata to the latest version 🚀#395
Merged
Conversation
googlebot
added
the
cla: yes
[email protected] is a semver major release. As it uses promises now, we can get rid of our promise wrappers. Simplify the tests – we don't need to test functionality provided by gcp-metadata.
JustinBeckwith
approved these changes
Feb 8, 2018
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
Deleting all that code looks amazing 😁
| } | ||
|
|
||
| static async runningOnGCP(): Promise<boolean> { | ||
| const lookup = promisify(dns.lookup); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 0.5.0 of gcp-metadata was just published.
The version 0.5.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of gcp-metadata.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 10 commits.
1841f3c0.5.09686277feat: add isAvailable method (#23)a042275feat: switch to promises (#24)ee6713bfix: use the v1 path and remove trailing dot (#28)2b107a1test: switch to ava (#27)99f29c9fix: use v1beta1 instead of v1 to support GCF (#25)d6d4454feat: Export host name and use.at the end (#22)b830edbchore: switch to axios (#20)0bfe4b0test: add tests for node 9 (#21)85a471dchore: reorganize structure a bit (#19)See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴