This repository was archived by the owner on Apr 3, 2024. It is now read-only.
chore: license check as posttest#384
Merged
jinwoo merged 2 commits intogoogleapis:masterfrom Jan 8, 2018
Merged
Conversation
There are two problematic dependencies: log-driver & modelo. They come from googleapis/nodejs-common. I created an issue for that: googleapis/nodejs-common#16. Until it's resolved, this repo must have a package whitelist.
googlebot
added
the
cla: yes
DominicKramer
approved these changes
Jan 8, 2018
Contributor
DominicKramer
left a comment
DominicKramer
left a comment
There was a problem hiding this comment.
Can you also add an issue to this repo to remove log-driver from the packageWhitelist when @google-cloud/common has been updated?
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "packageWhitelist": [ | |||
| "log-driver" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Filed #387 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two problematic dependencies: log-driver & modelo. They come
from googleapis/nodejs-common. I created an issue for that:
googleapis/nodejs-common#16. Until it's
resolved, this repo must have a package whitelist.