fix: refuse to start if working dir is root dir by DominicKramer · Pull Request #381 · googleapis/cloud-debug-nodejs

DominicKramer · 2017-12-20T20:06:57Z

fixes: #377

ofrobots

Commit and PR should include 'Fixes:' metadata.

src/agent/debuglet.ts

+      that.emit(
+          'initError',
+          new Error(
+              `Cannot start the agent when the working directory is a root directory`));


src/agent/debuglet.ts

+    // Don't continue if the working directory is a root directory
+    if (path.join(workingDir, '..') === workingDir) {
+      that.logger.error(
+          `Refusing to start with \`workingDirectory\` set to a root directory:  '${


test/test-debuglet.ts

      assert.deepEqual(mergedConfig, compareConfig);
    });

+    it('should not start when workingDirectory is the a directory', (done) => {


test/test-debuglet.ts


+    it('should not start when workingDirectory is the a directory', (done) => {
+      const debug = new Debug({}, packageInfo);
+      const config = extend({}, defaultConfig, {workingDirectory: path.sep});


test/test-debuglet.ts

+      };
+
+      debuglet.on('initError', (err: Error) => {
+        assert.ok(err);


src/agent/debuglet.ts

+    if (!that.config.allowRootAsWorkingDirectory &&
+        path.join(workingDir, '..') === workingDir) {
+      const message =
+          `Refusing to start the cloud debugger with \`workingDirectory\` set to a root ` +


ofrobots

LGTM w/ nit if the CI is happy.

fix: Refuse to start if working dir is root dir

4a68901

DominicKramer requested a review from ofrobots December 20, 2017 20:06

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2017

DominicKramer added 2 commits December 20, 2017 12:07

Run gts fix

e13f6f7

Make tests work on Windows and Unix

2cf48a9

ofrobots changed the title ~~fix: Refuse to start if working dir is root dir~~ fix: refuse to start if working dir is root dir Dec 20, 2017

ofrobots suggested changes Dec 20, 2017

View reviewed changes

ofrobots reviewed Dec 20, 2017

View reviewed changes

src/agent/debuglet.ts Outdated

that.emit(

'initError',

new Error(

`Cannot start the agent when the working directory is a root directory`));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

kjin reviewed Dec 20, 2017

View reviewed changes

DominicKramer added 2 commits December 20, 2017 14:00

Add comments to the debuglet test

e782e1e

Address GitHub comments

9bc9f89

DominicKramer mentioned this pull request Dec 20, 2017

GKE: Error scanning the filesystem #377

Closed

DominicKramer added 3 commits December 20, 2017 15:02

Add config option allowRootAsWorkingDirectory

6459734

Run gts fix

7ad9c69

Add a comment

bb9d1f8

ofrobots reviewed Dec 20, 2017

View reviewed changes

src/agent/debuglet.ts Outdated

if (!that.config.allowRootAsWorkingDirectory &&

path.join(workingDir, '..') === workingDir) {

const message =

`Refusing to start the cloud debugger with \`workingDirectory\` set to a root ` +

This comment was marked as spam.

Sign in to view

ofrobots approved these changes Dec 20, 2017

View reviewed changes

Update the error message

501e429

kjin approved these changes Dec 20, 2017

View reviewed changes

DominicKramer merged commit 3b97598 into googleapis:master Dec 21, 2017

Conversation

DominicKramer commented Dec 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ofrobots left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ofrobots left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DominicKramer commented Dec 20, 2017 •

edited

Loading