This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: Address startup failure from file access errors#379
Merged
DominicKramer merged 16 commits intogoogleapis:masterfrom Dec 20, 2017
Merged
fix: Address startup failure from file access errors#379DominicKramer merged 16 commits intogoogleapis:masterfrom
DominicKramer merged 16 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
ofrobots
reviewed
Dec 18, 2017
src/agent/debuglet.ts
Outdated
| try { | ||
| fileStats = await scanner.scan( | ||
| !id, that.config.workingDirectory, /.js$|.map$/); | ||
| fileStats.errors().forEach(err => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/agent/io/scanner.ts
Outdated
| reject(error); | ||
| } | ||
| else { | ||
| let d: string|undefined; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -0,0 +1 @@ | |||
| This file cannot be read. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
DominicKramer
force-pushed
the
fix/startup-error-on-bad-files
branch
from
55275db to
3eba764
Compare
ofrobots
approved these changes
Dec 20, 2017
|
|
||
| it('should not fail if files cannot be read', (done) => { | ||
| const MOCKED_DIRECTORY = process.cwd(); | ||
| const errors: Array < { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also tests were added to verify that if a file cannot be read during a filesystem scan, a warning is issued instead of an error.
DominicKramer
force-pushed
the
fix/startup-error-on-bad-files
branch
from
3eba764 to
0250fe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #377