This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: Remove the process warning listener#376
Merged
DominicKramer merged 1 commit intogoogleapis:masterfrom Dec 12, 2017
Merged
Conversation
Node 8.5.0 introduced a change where a warning message discussing the use of async traces would be printed when using the debug agent with the inspector protocol. At that time, a listener was added that listened to that warning and also printed a message stating that the warning does not impact the debug agent. At this point, the underlying issue causing the warning message to appear has been fixed in Node, and, as such, the associated warning listener in the debug agent has be removed.
googlebot
added
the
cla: yes
jinwoo
approved these changes
Dec 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 8.5.0 introduced a change where a warning message discussing
the use of async traces would be printed when using the debug
agent with the inspector protocol. At that time, a listener was
added that listened to that warning and also printed a message
stating that the warning does not impact the debug agent.
At this point, the underlying issue causing the warning message to
appear has been fixed in Node, and, as such, the associated warning
listener in the debug agent has be removed.