This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: only look for relevant files in scanner test#372
Merged
DominicKramer merged 2 commits intogoogleapis:masterfrom Dec 8, 2017
Merged
Conversation
The `scanner` tests would scan all files in the `coffee` fixtures directory to make sure the `all` and `selectFiles` methods work correctly. However, the initial scan would incorrectly capture `.DS_Store` files if they were present in the `coffee` directory.
googlebot
added
the
cla: yes
ofrobots
changed the title
scanner tests
ofrobots
reviewed
Dec 8, 2017
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM. I made some edits in the PR title to make it more useful. 'fix: Fix a bug in ${some} test' is very redundant. It is better to be able to say what is being fixed in the abstract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
scannertests would scan all files in thecoffeefixturesdirectory to make sure the
allandselectFilesmethods workcorrectly. However, the initial scan would incorrectly capture
.DS_Storefiles if they were present in thecoffeedirectory.