Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

fix: index only .js.map source map files#371

Merged
DominicKramer merged 5 commits intogoogleapis:masterfrom
DominicKramer:fix/handle-non-js-sourcemaps
Dec 20, 2017
Merged

fix: index only .js.map source map files#371
DominicKramer merged 5 commits intogoogleapis:masterfrom
DominicKramer:fix/handle-non-js-sourcemaps

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

fixes: #366

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2017
@ofrobots
Copy link
Copy Markdown
Contributor

ofrobots commented Dec 7, 2017

Can you add a test for this?

@ofrobots ofrobots changed the title fix: Only provide .js.map files to Sourcemapper fix: only index .js.map files Dec 7, 2017
@ofrobots ofrobots changed the title fix: only index .js.map files fix: index only .js.map source map files Dec 7, 2017
@DominicKramer DominicKramer force-pushed the fix/handle-non-js-sourcemaps branch 2 times, most recently from 651e46e to 0cc19c0 Compare December 18, 2017 18:30
@DominicKramer DominicKramer requested a review from a team December 18, 2017 20:17
@DominicKramer DominicKramer force-pushed the fix/handle-non-js-sourcemaps branch from fbb8205 to 86959d5 Compare December 19, 2017 23:25
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ nit.

return extend(true, {}, defaultConfig, config, envConfig);
}

static async findFiles(shouldHash: boolean, baseDir: string): Promise<{

This comment was marked as spam.

This comment was marked as spam.

@DominicKramer DominicKramer merged commit e38854e into googleapis:master Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gracefully handle unexpected source maps

3 participants