This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: Address compilation errors when using the agent with Typescript#370
Merged
DominicKramer merged 11 commits intogoogleapis:masterfrom Dec 8, 2017
Merged
Conversation
googlebot
added
the
cla: yes
DominicKramer
changed the title
gts
Closed
This is needed because otherwise importing the module has a compile time error because of an implicit cast to `any`.
DominicKramer
force-pushed
the
test/install-tests-use-gts
branch
from
b5d6782 to
6f8d215
Compare
kjin
reviewed
Dec 7, 2017
src/agent/config.ts
Outdated
| testMode_?: boolean; | ||
| } | ||
|
|
||
| export interface ResolvedDebugAgentConfig extends DebugAgentConfig { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Additional nit -- PR title should be |
DominicKramer
changed the title
kjin
reviewed
Dec 7, 2017
|
|
||
| export interface DebugAgentConfig extends common.AuthenticationConfig { | ||
| export type DebugAgentConfig = { | ||
| [K in keyof ResolvedDebugAgentConfig]?: Partial<ResolvedDebugAgentConfig[K]> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kjin
previously approved these changes
Dec 7, 2017
Contributor
Author
|
@kjin I uploaded a new commit that added additional installation tests. |
kjin
approved these changes
Dec 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #367