Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

chore: Run gts fix and manually fix some errors#369

Merged
DominicKramer merged 12 commits intogoogleapis:masterfrom
DominicKramer:chore/address-gts-errors
Dec 6, 2017
Merged

chore: Run gts fix and manually fix some errors#369
DominicKramer merged 12 commits intogoogleapis:masterfrom
DominicKramer:chore/address-gts-errors

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2017
@DominicKramer DominicKramer requested a review from a team December 6, 2017 18:44
const that = this;
process.on('warning', (warning) => {
if ((warning as any).code ===
if ((warning as {} as {code: string}).code ===

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

timesliceEnd = currTime + 1000;
}
print(
// TODO: Address the case where `breakpoint.logMessageFormat` is

This comment was marked as spam.

This comment was marked as spam.

// TODO: Determine how to remove this cast to any.
assert(bp.variableTable.some(function(v) {
// TODO: Handle the case when v is undefined
// TODO: Handle the case when v.status is undefined

This comment was marked as spam.

This comment was marked as spam.

Copy link
Copy Markdown
Contributor

@jinwoo jinwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the change about the code field in the error.

@DominicKramer DominicKramer merged commit d7bec41 into googleapis:master Dec 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants