Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

test: add installation verification#359

Merged
DominicKramer merged 11 commits intogoogleapis:masterfrom
DominicKramer:test/add-install-check
Nov 15, 2017
Merged

test: add installation verification#359
DominicKramer merged 11 commits intogoogleapis:masterfrom
DominicKramer:test/add-install-check

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

@DominicKramer DominicKramer commented Nov 10, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2017
@DominicKramer DominicKramer requested a review from a team November 10, 2017 01:57
@ofrobots ofrobots changed the title test: Add installation verification test: add installation verification Nov 10, 2017
ofrobots
ofrobots reviewed Nov 11, 2017
View reviewed changes
test/test-install.ts
@@ -0,0 +1,97 @@

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/test-install.ts Outdated
});

TS_CODE.forEach((code) => {
it(`Should install and work with the Typescript code:\n${code}`, async function() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/test-install.ts Outdated
});

JS_CODE.forEach((code) => {
it(`Should install and work with the Javascript code:\n${code}`, async function() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/utils.ts
@@ -0,0 +1,66 @@

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tsconfig.json Outdated
"node_modules",
"test/fixtures"
]
} No newline at end of file

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

package.json Outdated
"posttest": "npm run check",
"prepack": "npm run compile",
"pretest-install": "npm run compile",
"test-install": "mocha build/test/test-install.js"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

gaofanmichael
gaofanmichael reviewed Nov 11, 2017
View reviewed changes
package.json Outdated
"posttest": "npm run check"
"posttest": "npm run check",
"prepack": "npm run compile",
"pretest-install": "npm run compile",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/utils.ts
return path.relative(BUILD_DIRECTORY, `node_modules/${nodule}`);
}

export function existsP(path: string): Promise<boolean> {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/utils.ts Outdated
});
}

export function spawnP(command: string, args?: string[], options?: SpawnOptions, log?: (text: string) => void): Promise<void> {

This comment was marked as spam.

Sign in to view

test/test-install.ts Outdated
debug.start({ allowExpressions: true });
`;

const TS_CODE = [TS_CODE_1, TS_CODE_2, TS_CODE_3];

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/test-install.ts Outdated
allowExpressions: true
})`;

const JS_CODE = [JS_CODE_1, JS_CODE_2, JS_CODE_3];

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@DominicKramer
Copy link
Copy Markdown
Contributor Author

DominicKramer commented Nov 14, 2017

@ofrobots @gaofanmichael PTAL

kjin
kjin approved these changes Nov 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end.

test/test-install.ts Outdated
});

TS_CODE_ARRAY.forEach((code) => {
it(`should install and work with the Typescript code:\n${code}`, async function() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/utils.ts
return path.relative(BUILD_DIRECTORY, `node_modules/${nodule}`);
}

export function existsP(path: string): Promise<boolean> {

This comment was marked as spam.

Sign in to view

tsconfig.json Outdated
"exclude": [
"node_modules"
"node_modules",
"test/fixtures"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@DominicKramer DominicKramer merged commit acdefca into googleapis:master Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@ofrobots ofrobots ofrobots left review comments

@kjin kjin kjin approved these changes

@gaofanmichael gaofanmichael gaofanmichael approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DominicKramer @ofrobots @kjin @gaofanmichael @jmdobry @googlebot