chore: Upgrade to Typescript `~2.6.1` by DominicKramer · Pull Request #355 · googleapis/cloud-debug-nodejs

DominicKramer · 2017-11-03T20:19:56Z

No description provided.

src/agent/debuglet.ts


-  static getProjectIdFromMetadata(): Promise<string> {
-    return new Promise<string>((resolve, reject) => {
+  static getProjectIdFromMetadata(): Promise<string|undefined> {


src/agent/debuglet.ts


-  static getClusterNameFromMetadata(): Promise<string> {
-    return new Promise<string>((resolve, reject) => {
+  static getClusterNameFromMetadata(): Promise<string|undefined> {


src/agent/debuglet.ts

      // TODO: Address the case when `that.debuggee` is `null`.
      that.controller.listBreakpoints(
-          (that.debuggee as Debuggee), function(err: Error, response, body) {
+          (that.debuggee as Debuggee), function(err: Error|null, response, body) {


src/agent/debuglet.ts

      metadata.instance(
          'attributes/cluster-name',
-          (err: Error, res: any, clusterName: string) => {
+          (err: Error|null, res?: request.RequestResponse, clusterName?: string) => {


ofrobots

LGTM w/ nits.

test/test-controller.ts

         const controller = new Controller(fakeDebug);
         controller.register(
-             debuggee, function(err: Error, result: {debuggee: Debuggee}) {
+             debuggee, function(err: Error|null, result?: {debuggee: Debuggee}) {


test/test-controller.ts

      // TODO: Determine if this type signature is correct.
      controller.register(
-          debuggee, function(err: Error|null, result: {debuggee: Debuggee}) {
+          debuggee, function(err: Error|null, result?: {debuggee: Debuggee}) {


test/test-controller.ts

            function(
-                err: Error|null, response: http.ServerResponse,
-                result: stackdriver.ListBreakpointsResponse) {
+                err: Error|null, response?: http.ServerResponse,


test/test-max-data-size.ts

    } as stackdriver.Breakpoint;
    // TODO: Determine how to remove this cast to any.
-    api.set(bp, function(err1: Error) {
+    api.set(bp, function(err1: Error|null) {


test/test-max-data-size.ts

      location: breakpointInFoo.location
    } as stackdriver.Breakpoint;
-    api.set(bp, function(err1: Error) {
+    api.set(bp, function(err1: Error|null) {


DominicKramer added 2 commits November 3, 2017 10:09

chore: Upgrade to Typescript ~2.6.1

d652f63

Fix compiler errors

1cd2879

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2017

jmdobry added the in progress label Nov 3, 2017

DominicKramer requested a review from gaofanmichael November 3, 2017 20:20

ofrobots reviewed Nov 3, 2017

View reviewed changes

DominicKramer added 3 commits November 3, 2017 16:10

Replace string|undefined with string

69d3886

Remove inferable return type annotations

fb25c1a

Remove unnecessary type annotations

729768b

ofrobots approved these changes Nov 3, 2017

View reviewed changes

Address GitHub comments

7a2a68b

DominicKramer merged commit cdee56f into googleapis:master Nov 6, 2017

jmdobry removed the in progress label Nov 6, 2017

Conversation

DominicKramer commented Nov 3, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ofrobots left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants