Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

fix: make debugee variables public#352

Merged
gaofanmichael merged 1 commit intogoogleapis:masterfrom
gaofanmichael:private
Nov 2, 2017
Merged

fix: make debugee variables public#352
gaofanmichael merged 1 commit intogoogleapis:masterfrom
gaofanmichael:private

Conversation

@gaofanmichael
Copy link
Copy Markdown
Contributor

@gaofanmichael gaofanmichael commented Nov 2, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2017
DominicKramer
DominicKramer approved these changes Nov 2, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@DominicKramer DominicKramer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as a description is added that describes why this change was needed and provided the tests pass.

@gaofanmichael gaofanmichael merged commit 185f1c2 into googleapis:master Nov 2, 2017
@gaofanmichael gaofanmichael deleted the private branch November 2, 2017 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@DominicKramer DominicKramer DominicKramer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaofanmichael @DominicKramer @jmdobry @googlebot