Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Skip 32bit platform warning test after node 8.9.0#351

Merged
gaofanmichael merged 1 commit intogoogleapis:masterfrom
gaofanmichael:warning
Nov 2, 2017
Merged

Skip 32bit platform warning test after node 8.9.0#351
gaofanmichael merged 1 commit intogoogleapis:masterfrom
gaofanmichael:warning

Conversation

@gaofanmichael
Copy link
Copy Markdown
Contributor

@gaofanmichael gaofanmichael commented Nov 2, 2017

As asnyc stack traces will not be turned on by default after node 8.9.0,
The warning message of 'async stack trace is not available on 32 bit
platform' no longer emitted. We will not emit this message after node
8.9.0.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2017
DominicKramer
DominicKramer approved these changes Nov 2, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the Debuggee private to public changes are moved to their own PR.

test/test-debuglet.ts Outdated
assert.equal((debuglet.debuggee_ as Debuggee).project, projectId);
const arch = process.arch;
if (semver.satisfies(process.version, '>=8.5') &&
semver.satisfies(process.version, '<8.9') &&

This comment was marked as spam.

Sign in to view

src/debuggee.ts Outdated
}

export class Debuggee {
private uniquifier: string;

This comment was marked as spam.

Sign in to view

@DominicKramer
Copy link
Copy Markdown
Contributor

DominicKramer commented Nov 2, 2017

I think the phrase As asnyc stack traces will not be turned on by default after node 8.9.0... should be changed to As asnyc stack traces will not be turned on by default starting with node 8.9.0 because async stack traces are not turned on by default in 8.9.0 but the original phrasing makes it sound like it is not until 8.9.0 that that change occurs.

@DominicKramer
Copy link
Copy Markdown
Contributor

DominicKramer commented Nov 2, 2017 •
edited
Loading

Also the title Skip 32bit platform warning test after node 8.9.0 would probably be better written as Skip 32bit platform warning starting with node 8.9.0.

@gaofanmichael gaofanmichael force-pushed the warning branch 2 times, most recently from d27a997 to 6acfdc1 Compare November 2, 2017 20:53
@gaofanmichael
fix: Skip 32bit platform warning starting on 8.9
52f973d 
As asnyc stack traces will not be turned on by default statring with node
8.9.0, The warning message of 'async stack trace is not available on 32 bit
platform' no longer emitted. We will not emit this elaboration to users.
@gaofanmichael gaofanmichael merged commit e108967 into googleapis:master Nov 2, 2017
@gaofanmichael gaofanmichael deleted the warning branch November 2, 2017 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@DominicKramer DominicKramer DominicKramer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaofanmichael @DominicKramer @jmdobry @googlebot