Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Allow a single direct access point to package.json#347

Merged
DominicKramer merged 5 commits intogoogleapis:masterfrom
DominicKramer:cleanup/single-direct-packagejson-access
Oct 25, 2017
Merged

Allow a single direct access point to package.json#347
DominicKramer merged 5 commits intogoogleapis:masterfrom
DominicKramer:cleanup/single-direct-packagejson-access

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2017
src/debuggee.ts Outdated
* TODO(ofrobots): has this been renamed to `status` in the API?
*/
constructor(properties: DebuggeeProperties) {
constructor(properties: DebuggeeProperties, appInfo: AppInfo) {

This comment was marked as spam.

This comment was marked as spam.

src/debuggee.ts Outdated
statusMessage?: StatusMessage;
}

export interface AppInfo {

This comment was marked as spam.

This comment was marked as spam.

src/debuggee.ts Outdated
* TODO(ofrobots): has this been renamed to `status` in the API?
*/
constructor(properties: DebuggeeProperties) {
constructor(properties: DebuggeeProperties, appInfo: AppInfo) {

This comment was marked as spam.

This comment was marked as spam.

Copy link
Copy Markdown
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DominicKramer DominicKramer merged commit b908545 into googleapis:master Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants