Use `gts` instead of `gulp` by DominicKramer · Pull Request #344 · googleapis/cloud-debug-nodejs

DominicKramer · 2017-10-20T21:04:40Z

No description provided.

gaofanmichael

The comments are all about formatter. Is there a reason we move underscore in variable name?
Could you please check the failed test as well?

test/debugger.ts

-    if (typeof(options) === 'function') {
+  listBreakpoints(
+      debuggeeId: string, options: {
+        includeAllUsers: boolean; includeInactive: boolean;


test/test-controller.ts

+      const scope =
+          nock(url)
+              .get(
+                  api +


test/test-debuglet.ts

+           nocks.oauth2();
+           const scope = nock(API)
+                             .post(
+                                 REGISTER_PATH,


test/test-this-context.ts

+              // TODO: Handle the case when mapper is undefined
+              // TODO: Handle the case when v8debugapi.create returns null
+              api =
+                  debugapi.create(


test/test-debuglet.ts

+           const arch = process.arch;
+           if (semver.satisfies(process.version, '>=8.5') &&
+               (arch === 'ia32' || arch === 'x86') &&
+               process.env['GCLOUD_USE_INSPECTOR']) {


scripts/setup-test.ts

+  }
+}
+
+main();


scripts-tsconfig.json

+  "exclude": [
+    "node_modules"
+  ]
+}


test/misc/bench.ts

 const fib = require('./bench-code.js');

-const logger = new Logger(config.logLevel);
+const logger = new (require('../src/logger.js'))(config.logLevel);


scripts/setup-test.ts

+    await setupUnitTests();
+    await setupSystemTests();
+  }
+  catch (e) {


ofrobots

LGTM, once remaining nit is addressed.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2017

jmdobry added the in progress label Oct 20, 2017

DominicKramer mentioned this pull request Oct 20, 2017

Use gts instead of gulp #342

Closed

DominicKramer force-pushed the cleanup/use-gts2 branch from 84a3329 to f4f93de Compare October 20, 2017 23:51

gaofanmichael reviewed Oct 23, 2017

View reviewed changes

gaofanmichael mentioned this pull request Oct 25, 2017

Support GCF through a 'initialization completed promise' #341

Closed

DominicKramer force-pushed the cleanup/use-gts2 branch from 73341fb to 446ffb7 Compare October 26, 2017 19:02

DominicKramer commented Oct 26, 2017

View reviewed changes

test/test-debuglet.ts Outdated

const arch = process.arch;

if (semver.satisfies(process.version, '>=8.5') &&

(arch === 'ia32' || arch === 'x86') &&

process.env['GCLOUD_USE_INSPECTOR']) {

This comment was marked as spam.

Sign in to view

ofrobots reviewed Oct 28, 2017

View reviewed changes

ofrobots approved these changes Nov 2, 2017

View reviewed changes

DominicKramer added 20 commits November 2, 2017 14:18

Use gts instead of gulp

5710bf3

Run gts fix

108e5b1

Replace underscore property names

51024b2

Fix compilation errors

ddb7c0f

Remove _name parameter names

a18e8dc

Remove name_ parameter names

4b1f22f

Fix //<no space> gts check errors

22781b8

Fix Logger name error with gts check

914d6c8

Fix no-unused-expression gts check errors

a41df87

Fix shadow variable name errors

99af0bc

Fix additional //<no space> errors

2f579be

Fix for in check errors

2b82ed8

Run gts fix

23d11d2

Fix gts check error

f72aa50

Run gts fix

aee474c

Run gts fix

80c7211

Fix .travis.yaml

269a7e6

Add newlines

6b29f82

Address GitHub comments

fb47485

Pin to a specific typescript version

f60b71a

DominicKramer force-pushed the cleanup/use-gts2 branch from 77f2c97 to f60b71a Compare November 2, 2017 21:25

DominicKramer merged commit b95bae2 into googleapis:master Nov 2, 2017

jmdobry removed the in progress label Nov 2, 2017

+                }
+              }
+              main();

                
                    No newline at end of file

Conversation

DominicKramer commented Oct 20, 2017

Uh oh!

gaofanmichael left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ofrobots left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants