Elaborate on async stack trace warning by gaofanmichael · Pull Request #340 · googleapis/cloud-debug-nodejs

gaofanmichael · 2017-10-11T22:50:02Z

Add a log message address the 'INSPECTOR_ASYNC_STACK_TRACES_NOT_AVAILABLE' warning.

src/agent/debuglet.ts

+          'INSPECTOR_ASYNC_STACK_TRACES_NOT_AVAILABLE') {
+        console.log(
+            'The current debug agent does not use Inspector async stack ' +
+            'traces. The above warning will not affect the debug agent.');


test/test-debuglet.ts

+    it('should elaborate on inspector warning on 32 bit', function(done) {
+      let logText = '';
+      const oldLog = console.log;
+      console.log = function(s: string) {


test/test-debuglet.ts

      assert.deepEqual(mergedConfig, compareConfig);
    });

+    it('should elaborate on inspector warning on 32 bit', function(done) {


test/test-debuglet.ts

+        const arch = process.arch;
+        const nodeVersion = /v(\d+\.\d+\.\d+)/.exec(process.version);
+        if (!nodeVersion || nodeVersion.length < 2) {
+          (assert as any).fail();


test/test-debuglet.ts

+        } else if (semver.satisfies(nodeVersion[1], '>=8') &&
+            (arch === 'ia32' || arch === 'x86')) {
+          assert(logText.includes(
+              'The current debug agent does not use ' +


src/agent/debuglet.ts

+          'INSPECTOR_ASYNC_STACK_TRACES_NOT_AVAILABLE') {
+        console.log(
+            'The current debug agent does not use Inspector async stack ' +
+            'traces. The above warning will not affect the debug agent.');


test/test-debuglet.ts

+    let oldLog: any;
+    beforeEach(() => {
      delete process.env.GCLOUD_PROJECT;
+      oldLog = console.log;


DominicKramer

LGTM with nits.

test/test-debuglet.ts

+        // TODO: Handle the case where debuglet.debuggee is undefined
+        assert.equal((debuglet.debuggee_ as Debuggee).project, projectId);
+        const arch = process.arch;
+        if (semver.satisfies(process.version, '>=8') &&


src/agent/util/utils.ts

  COULD_NOT_FIND_OUTPUT_FILE:
-      'Could not determine the output file associated with the transpiled input file'
+      'Could not determine the output file associated with the transpiled input file',
+  ASYNC_TRACES_WARNING: 'The Stackdriver debug agent does not use Inspector ' +


test/test-debuglet.ts

    after(function() { process.env.GCLOUD_PROJECT = oldGP; });
-
-    beforeEach(function() {
+    beforeEach(() => {


test/test-debuglet.ts

    });

-    afterEach(function() { nock.cleanAll(); });
+    afterEach(() => {


gaofanmichael requested review from DominicKramer and ofrobots October 11, 2017 22:50

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2017

jmdobry added the in progress label Oct 11, 2017

gaofanmichael changed the title ~~elaboration on async stack trace warning~~ Elaborate on async stack trace warning Oct 11, 2017

Elaborate on async stack trace warning

b89a553

gaofanmichael force-pushed the warning branch from eb55ee2 to b89a553 Compare October 11, 2017 23:26

Add test

89cf41c

gaofanmichael force-pushed the warning branch 3 times, most recently from 0508566 to f30a52e Compare October 12, 2017 01:01

Fix node 4/6 on windows

e3ce1fb

gaofanmichael force-pushed the warning branch from f30a52e to e3ce1fb Compare October 12, 2017 01:14

DominicKramer reviewed Oct 16, 2017

View reviewed changes

gaofanmichael added 2 commits October 16, 2017 13:13

respond to comments

a8b6729

use logger instead of console.log

d41cf75

DominicKramer reviewed Oct 19, 2017

View reviewed changes

test/test-debuglet.ts Outdated

let oldLog: any;

beforeEach(() => {

delete process.env.GCLOUD_PROJECT;

oldLog = console.log;

This comment was marked as spam.

Sign in to view

remove dead code

56c8dfe

DominicKramer approved these changes Oct 20, 2017

View reviewed changes

resolve comments

01666c9

gaofanmichael merged commit 964cc31 into googleapis:master Oct 20, 2017

gaofanmichael deleted the warning branch October 20, 2017 18:33

jmdobry removed the in progress label Oct 20, 2017

Conversation

gaofanmichael commented Oct 11, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

DominicKramer left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants