This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Remove args in state.ts#resolveLocalList#331
Merged
gaofanmichael merged 1 commit intogoogleapis:masterfrom Sep 19, 2017
Merged
Conversation
Though cloud debugger has args in the proto, args is used to identify passing variables to the functions. Locals, on the other hand is the local variables defined within the function. However, stackdriver debugger UI displays them in the same place with the order of passing variables prior to local variables. In our case, debugger's call frame will have the same effects of ordering passing variables prior to local variables. We can sufficiently merge args and locals in one place. That's the reason of removing args in the code.
gaofanmichael
added
cla: yes
gaofanmichael
requested review from
DominicKramer,
kjin,
matthewloring and
ofrobots
matthewloring
approved these changes
Sep 19, 2017
ofrobots
approved these changes
Sep 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though cloud debugger has args in the proto, args is used to identify
passing variables to the functions. Locals, on the other hand is the
local variables defined within the function. However, stackdriver
debugger UI displays them in the same place with the order of passing
variables prior to local variables. In our case, debugger's call frame
will have the same effects of ordering passing variables prior to local
variables. We can sufficiently merge args and locals in one place.
That's the reason of removing args in the code.